hey icon indicating copy to clipboard operation
hey copied to clipboard

changes to filter conversations as followed and requested

Open bhavya2611 opened this issue 2 years ago • 3 comments

What does this PR do?

Adds the following and requested tab in the conversations preview list to avoid spam.

Type of change

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Enhancement (small non-breaking changes to existing functionality)

How should this be tested?

  • [ ] Check if the conversations from the profiles you follow and you don't are displayed in the correct tabs
  • [ ] Try to switch between tabs
  • [ ] Select a conversation and message them
  • [ ] Search a profile and from the profiles, page click on the message button and see if routing is good

Screenshots

image

image

bhavya2611 avatar Nov 07 '22 09:11 bhavya2611

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 4:15PM (UTC)

vercel[bot] avatar Nov 07 '22 09:11 vercel[bot]

I'm not seeing any DMs in following tab 🤔 but I have lotta DMs from people I follow 🤔

Screenshot 2022-11-07 at 6 59 16 PM

bigint avatar Nov 07 '22 13:11 bigint

@bhavya2611 oooh i found one more case that we prob want to handle:

if i tap the "follow" button on a person in the requested tab, i'd expect that convo to move over to "following". also prob vice-versa where if i "unfollow" they move to the other side. would this be v difficult?

elisealix22 avatar Nov 08 '22 17:11 elisealix22

@bigint did the latest round of changes fix your issue? I am seeing profiles correctly partitioned in the preview deployment.

neekolas avatar Nov 08 '22 20:11 neekolas

@elisealix22 can be done, but the problem is that the follow, unfollow state to reflect takes time, I can on the basis of that it went through can move a profile over, but if the state refreshes due to any reason the conversation will again move to the previous tab, till the profile object finally reflects it.

bhavya2611 avatar Nov 09 '22 14:11 bhavya2611

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Nov 09 '22 16:11 gitpoap-bot[bot]