hey icon indicating copy to clipboard operation
hey copied to clipboard

feat!: replace current text editor

Open harish-sethuraman opened this issue 3 years ago • 1 comments

What does this PR do?

Replaces current text editor with new one

https://user-images.githubusercontent.com/32865581/199824651-308ae2ac-5cb0-4e8b-bcfe-95558cdbcd31.mov

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Enhancement (non-breaking small changes to existing functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How should this be tested?

  • test new changes features
  • test existing texts as well

harish-sethuraman avatar Nov 03 '22 20:11 harish-sethuraman

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 12, 2022 at 0:09AM (UTC)

vercel[bot] avatar Nov 03 '22 20:11 vercel[bot]

Da resolve conflicts 🙏🏼

bigint avatar Nov 11 '22 03:11 bigint

We can remove this bg color 🙏🏼, it doesn't match with our brand 🙇🏼

image

bigint avatar Nov 11 '22 08:11 bigint

Should we do a light purple?

harish-sethuraman avatar Nov 11 '22 08:11 harish-sethuraman

Should we do a light purple?

we can remove it

bigint avatar Nov 11 '22 08:11 bigint

This is to highlight that there is a mention in text editor. If we remove it it might kinda be a little confusing? 😅

harish-sethuraman avatar Nov 11 '22 08:11 harish-sethuraman

@harish-sethuraman publicationContent not getting cleared when we call setPublicationContent('') 😕

bigint avatar Nov 11 '22 13:11 bigint

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Nov 12 '22 12:11 gitpoap-bot[bot]