heylinda-app icon indicating copy to clipboard operation
heylinda-app copied to clipboard

fixed display of hour plus long tracks

Open thehalvo opened this issue 2 years ago • 3 comments

Description

If a meditation track was greater than 59:59 it would not display the hours. It would just leave them out.

Ticket Link

N/A

How has this been tested?

Tested the play screen using these devices:

iPhone 13 - Simulator

Screenshots

Screen Shot 2022-06-24 at 12 12 59 AM

Checklist

  • [ ] Added a "Closes [issue number]" in the ticket link section
  • [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens

thehalvo avatar Jun 24 '22 04:06 thehalvo

Deploy Preview for webheylinda ready!

Name Link
Latest commit 2bce04a0d095f6c79a79cc9c7414b472b86ced3c
Latest deploy log https://app.netlify.com/sites/webheylinda/deploys/64a304931b46c200089aa2f1
Deploy Preview https://deploy-preview-153--webheylinda.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 24 '22 04:06 netlify[bot]

Awesome @thehalvo!

Thanks for fixing this issue. Can you add some additional tests for this case here so we don't ever regress: https://github.com/heylinda/heylinda-app/blob/main/hooks/tests/useMsToTime.tests.ts

watadarkstar avatar Jun 24 '22 15:06 watadarkstar

@watadarkstar sure done.

thehalvo avatar Jun 24 '22 21:06 thehalvo