hex icon indicating copy to clipboard operation
hex copied to clipboard

Finish transition to hex_core

Open wojtekmach opened this issue 4 years ago • 5 comments

We're already using hex_core in a few places, this is what is left:

  • [ ] Replace Hex.API.* with :hex_api_*.
  • [ ] Add progress tracking to hex_core
  • [x] Convert Hex.HTTP to a :hex_http adapter
  • [x] Update Hex.Repo to :hex_repo to fetch data
  • [ ] Move Hex.Crypto* to hex_core
  • [ ] Remove Hex.Crypto in favor of directly vendored pbcs

wojtekmach avatar Jan 21 '20 20:01 wojtekmach

@wojtekmach are any of the items still required to be done?

cgerling avatar Nov 15 '22 21:11 cgerling

@cgerling They are all up for grabs 👍

ericmj avatar Nov 22 '22 17:11 ericmj

Cool, I intend to create a PR to address the 1st, 3rd, and 4th items.

cgerling avatar Nov 24 '22 20:11 cgerling

I noticed that :hex_repo doesn't have some functions that Hex.Repo needs, like get_docs/3, get_public_key/1, and get_installs/0, should I add those in hex_core before updating Hex.Repo?

cgerling avatar Apr 01 '23 02:04 cgerling

I noticed that :hex_repo doesn't have some functions that Hex.Repo needs, like get_docs/3, get_public_key/1, and get_installs/0, should I add those in hex_core before updating Hex.Repo?

Yes. Can you open a PR to hex_core that adds the necessary functions?

ericmj avatar Apr 27 '23 19:04 ericmj