vecty icon indicating copy to clipboard operation
vecty copied to clipboard

Achieve 100% test coverage

Open emidoots opened this issue 8 years ago • 2 comments

Will need to make our testing suite much less verbose for this. Ideally we will just perform some Vecty operations in the test suite (e.g. RenderBody) and get an output list of strings or something non-verbose of exactly which DOM operations occurred.

Things we should also ensure we have tests for:

  • [ ] Add testing for 'idiomatic way to pass child component lists into an element's constructor' #78
  • [ ] #167
  • [ ] #249 (RenderInto / RenderIntoNode)

emidoots avatar Nov 09 '17 06:11 emidoots

@pdf FYI I haven't finished yet but I do have a quite extensive change to move us over to a nicer test suite that is more data-driven and just produces a list of expected vs. gotten DOM operations & will make it much easier to test correct behavior in Vecty without writing crazy verbose DOM mocking code. Just wanted to let you know so you don't do anything too extensive in the test suite any time soon :)

emidoots avatar Dec 04 '17 02:12 emidoots

Actually I had some spare hours, so I moved the entire test suite over and sent https://github.com/gopherjs/vecty/pull/178 :)

Still todo here is adding more tests to achieve 100% coverage, but it should be a lot easier once that PR is merged.

emidoots avatar Dec 04 '17 05:12 emidoots