hexo-generator-feed icon indicating copy to clipboard operation
hexo-generator-feed copied to clipboard

Disable comments or make it customizable

Open jiangtj opened this issue 4 years ago • 3 comments

https://github.com/hexojs/hexo-generator-feed/blob/60fe0b54b25e9764ec4b1924095eb9ababbfc577/rss2.xml#L57-L59

If post.comment is true, it will set disqus comment uri, but it is not all people use disqus.

I think it's better to disable comments or make it customizable

jiangtj avatar Aug 10 '20 08:08 jiangtj

Hi,

It seems to be a legitimate request. What kind of comments are you using ? Would it be enough to make the "#disqus_thread" customizable ?

tomap avatar Aug 15 '20 14:08 tomap

FYI, Hexo never add comment nor comments during processing. Thus in most case the comment won't exist.

SukkaW avatar Aug 15 '20 16:08 SukkaW

FYI, Hexo never add comment nor comments during processing. Thus in most case the comment won't exist.

By default, comments is true https://github.com/hexojs/hexo/blob/2dfaa6a600594ed5d087da683d67b7bc83fd2646/lib/models/page.js#L23

What kind of comments are you using ?

disqus 😂 , this problem didn't affect me, I just found it by accident

Would it be enough to make the "#disqus_thread" customizable ?

Maybe add another page variable, e.g. comments_url?

jiangtj avatar Aug 17 '20 01:08 jiangtj