codebattle icon indicating copy to clipboard operation
codebattle copied to clipboard

Mode vim mode does not work or it works

Open ilyar opened this issue 3 years ago • 7 comments

The vim mode does not work or it works, but my expectations do not match. I assume this is vim editor emulation mode. At the moment I'm observing that vim switch has no effect on editor's behavior, I checked it in Google Chrome Version 89.0.4389.90.

How should vim mode work?

ilyar avatar Apr 02 '21 13:04 ilyar

I assume this is vim editor emulation mode

Yes, we are using https://www.npmjs.com/package/monaco-vim. It only adds keybindings for monaco editor. We will check, thanks.

ReDBrother avatar Apr 02 '21 13:04 ReDBrother

I checked monaco-vim https://monaco-vim.ilyar.repl.co/ it is ok, but in codebattle editor not same

ilyar avatar Apr 02 '21 13:04 ilyar

https://github.com/hexlet-codebattle/codebattle/blob/140e5a15833b3a05934be2eb28da59e3ca745bcb/services/app/assets/js/widgets/containers/Editor.jsx#L6 https://github.com/hexlet-codebattle/codebattle/blob/140e5a15833b3a05934be2eb28da59e3ca745bcb/services/app/assets/js/widgets/containers/Editor.jsx#L66

ReDBrother avatar Apr 02 '21 14:04 ReDBrother

Maybe some keybindings are being replaced by custom rules in Editor.jsx. I'don't know yet.

ReDBrother avatar Apr 02 '21 14:04 ReDBrother

Using vim mode all the time, didn't have any problems.

vtm9 avatar Apr 21 '21 19:04 vtm9

cannot reproduce

vtm9 avatar Apr 21 '21 19:04 vtm9

I checked monaco-vim https://monaco-vim.ilyar.repl.co/ it is ok, but in codebattle editor not same

Same. In codebattle vim mode doesn't work, but it does work in https://monaco-vim.ilyar.repl.co/.

Browser: Chromium 102.

Layerex avatar Jun 15 '22 18:06 Layerex

Yeah, it doesn't work

vtm9 avatar Sep 03 '22 09:09 vtm9