codebattle icon indicating copy to clipboard operation
codebattle copied to clipboard

Fix rematch after timeouts: terminate the game after 15 minutes passe…

Open thepry opened this issue 2 years ago • 1 comments

  1. Fix rematch after timeouts: terminate the game after 15 minutes passed since the timeout instead of terminating it right away.
  2. Move timeouts whitelist to configs.
  3. Disable new credo checks: Credo.Check.Refactor.MapJoin, Credo.Check.Refactor.FilterFilter, since they make code less readable.

github-icon closes #ISSUE_ID

thepry avatar May 17 '22 12:05 thepry

Codecov Report

Merging #1101 (51319dd) into master (2535483) will decrease coverage by 0.31%. The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   70.02%   69.70%   -0.32%     
==========================================
  Files         125      125              
  Lines        2599     2608       +9     
==========================================
- Hits         1820     1818       -2     
- Misses        779      790      +11     
Impacted Files Coverage Δ
...app/lib/codebattle/game_process/engine/standard.ex 98.61% <ø> (ø)
services/app/lib/codebattle/game_process/play.ex 65.55% <62.50%> (-16.38%) :arrow_down:
services/app/lib/codebattle/game_process/fsm.ex 84.00% <100.00%> (+0.66%) :arrow_up:
...es/app/lib/codebattle_web/channels/game_channel.ex 86.48% <0.00%> (+6.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2535483...51319dd. Read the comment docs.

codecov-commenter avatar May 17 '22 12:05 codecov-commenter

сорри, я перефигачил весь бек, заодно пофиксил это. Приведу ишуес в актуальное состояние

vtm9 avatar Sep 03 '22 09:09 vtm9