hexchain comments

Results 60 comments of


                                            hexchain

http-cache-semantics: upgrade types to match upstream release 4.2.0

Cc @kornelski, the original library author, please also take a look if you are interested. Thanks!

http-cache-semantics: upgrade types to match upstream release 4.2.0

@rbuckton, thanks for approving! I have a question though: the updated types in this PR targets upstream release v4.2.0, which is still beta. I've set the version number to `4.1.9999`...

http-cache-semantics: upgrade types to match upstream release 4.2.0

There are a few changes I'd like to see before merging.

Question: share a single log thread between multiple worker threads

Thanks for the suggestion, but I don't think that is what I wanted. An example might make it clear: ```es6 import process from 'node:process'; import { Worker, isMainThread, threadId }...

fix: correctly handle multi-value headers in fetch when `rawHeaders` contains array

I've pushed a different fix as discussed in https://github.com/nodejs/undici/pull/4390#discussion_r2259309353. Please take a look, thanks!

fix: correctly handle multi-value headers in fetch when `rawHeaders` contains array

Gentle ping. May I have some reviews again? The latest change only touches `fetch` and not (Un)wrapHandlers, so no changes to existing interceptor/handler behaviors. Duplicate headers are processed mostly in...

fix: correctly handle multi-value headers in fetch when `rawHeaders` contains array

@metcoder95 By "interceptor" do you mean Wrap/UnwrapHandler? There is (almost) no interceptor involved in the original reproducer.

fix: correctly handle multi-value headers in fetch when `rawHeaders` contains array

I believe that was also the very first iteration of this PR. I'll try to summarize the situation and hopefully uncover a clear path forward. The issue happens because the...

Set-Cookie header gets concatenated in fetch if an interceptor is in place

I took a stab at this by changing `WrapHandler`. Another possible fix is to modify `httpNetworkFetch->dispatch->onHeaders` instead. Please let me know if that is preferred.

Set-Cookie header gets concatenated in fetch if an interceptor is in place

Arrays are fine for "parsed" headers of type `Record`, but maybe not for "raw" header. This issue happens because an array appeared in a "raw" header, e.g.: ``` [key: Buffer,...