spot_ros icon indicating copy to clipboard operation
spot_ros copied to clipboard

Odometry twist is erroneously reported in odom frame

Open peci1 opened this issue 1 year ago • 2 comments

According to Odometry message docs, twist should be expressed in the child frame, which is body.

According to Bodsdyn API docs, velocity_of_body_in_odom is expressed in odom frame.

Thus the twist published by the driver is invalid for downstream nodes that expect it to be in body frame.

https://github.com/heuristicus/spot_ros/blob/e71e726ee48328985a6015f634acd531e3935e92/spot_driver/src/spot_driver/ros_helpers.py#L290-L296

Note that fixing this bug could break downstream code that has already adapted to this deviation from the standard, so care has to be taken.

peci1 avatar Oct 21 '22 17:10 peci1