hcloud-cloud-controller-manager icon indicating copy to clipboard operation
hcloud-cloud-controller-manager copied to clipboard

Fix inverted feature names

Open andsens opened this issue 7 months ago • 2 comments

I would like to suggest renaming some loadbalancer annotations and their defaults in the upcoming v2.0.

The following annotations have negated names:

load-balancer.hetzner.cloud/ipv6-disabled (false)
load-balancer.hetzner.cloud/disable-public-network (false)
load-balancer.hetzner.cloud/disable-private-ingress (false)

Generally it is confusing to read code with negations, e.g. dontDoTheThing=false. It requires unnecessary brainpower to calculate whether that means that the thing is being done or not. So my suggestion would be to negate the names and the defaults:

load-balancer.hetzner.cloud/enable-ipv6 (true)
load-balancer.hetzner.cloud/use-public-network (true)
load-balancer.hetzner.cloud/allow-private-ingress (true)

I haven't checked whether there are other places where this would make sense.

andsens avatar Mar 06 '25 14:03 andsens