LoadBalancer does not populate IP field when `disable-public-network` is set.

[kwohlfahrt]

I have created a service of type LoadBalancer, with the annotation load-balancer.hetzner.cloud/disable-public-network: "true". The load-balancer has a private IP address assigned on my cluster's network (172.29.0.3), and responds correctly on this address. But, the status does not contain the LB's IP address:

  status:
    loadBalancer: {}

When I create a service without the annotation, the status is correctly updated:

  status:
    loadBalancer:
      ingress:
      - ip: 167.235.<snip>
      - ip: 2a01:4f8:<snip>

I think even if public access is disabled, the external IP should still be populated with the service's private network address, so that servers on my HCloud network (but outside the k8s cluster) can extract the address they can reach the service on. Also, without the load-balancer IP address, external-dns fails to add a record for this load-balancer.

[apricote]

Yea, this seems to be an oversight. I will cleanup the responsible code and submit a fix to include the private IP if disable-public-network is set. In theory we could always set this if a private network is defined, but that should probably be gated behind a flag, to avoid breaking users with external-dns setups (and similiar).

[github-actions[bot]]

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

[kwohlfahrt]

Not stale, this issue persists with 1.19 of the CCM.