csi-driver icon indicating copy to clipboard operation
csi-driver copied to clipboard

Docker Swarm support: Remove mock staging/unstaging once possible

Open s4ke opened this issue 2 years ago • 12 comments

In the original PR #376 we added a workaround where we added mock staging/unstaging support that will not be needed anymore once https://github.com/moby/swarmkit/pull/3116 is merged.

This issue is here to track this TODO.

s4ke avatar Feb 17 '23 12:02 s4ke

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

github-actions[bot] avatar May 18 '23 12:05 github-actions[bot]

This should work without by now. I havent gotten around to preparing a PR yet.

s4ke avatar May 18 '23 12:05 s4ke

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

github-actions[bot] avatar Aug 18 '23 12:08 github-actions[bot]

Hey @s4ke, could you implement this?

apricote avatar Sep 18 '23 12:09 apricote

Yes I can, but I have to see where it fits my schedule. Any hard deadline for when you want this in?

s4ke avatar Sep 18 '23 16:09 s4ke

Wonderful :) No deadline, would just love to see this done before the stale bot tries to close it again (~3 months)

apricote avatar Sep 19 '23 05:09 apricote

May I ask you to remind me if this is still not done in let's say, 1 month? Sorry, currently a bit busy :)

s4ke avatar Sep 19 '23 06:09 s4ke

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

github-actions[bot] avatar Dec 18 '23 12:12 github-actions[bot]

Well, I forgot about it :D @s4ke ping.

apricote avatar Jan 08 '24 07:01 apricote

Same here. If anyone else wants to take this, this is probably also a good first issue since it is just about removing operations and testing once against a Swarm.

s4ke avatar Jan 18 '24 08:01 s4ke

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

github-actions[bot] avatar Apr 17 '24 12:04 github-actions[bot]

If anyone wants to send a PR:

  • Revert commit https://github.com/hetznercloud/csi-driver/pull/376/commits/619fa5c3996e17e84b09deca0c956229e5554c77
  • Test against a current version of Docker Swarm

apricote avatar Apr 22 '24 09:04 apricote