cli icon indicating copy to clipboard operation
cli copied to clipboard

feat!: remove deprecated backup window flag

Open phm07 opened this issue 1 year ago • 4 comments

This flag has been deprecated (and not working) since 2018: https://github.com/hetznercloud/cli/pull/147

phm07 avatar Mar 07 '24 14:03 phm07

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.14%. Comparing base (f2fb321) to head (2bddf46). Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   60.14%   60.14%   -0.01%     
==========================================
  Files         191      191              
  Lines        6808     6802       -6     
==========================================
- Hits         4095     4091       -4     
+ Misses       2099     2098       -1     
+ Partials      614      613       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 14:03 codecov[bot]

This is a potentially breaking change. Even though this flag shows a warning since 2018, we should try to avoid making breaking changes on purpose.

I have created a v2 milestone and added this PR to it, so we have a list of things to tackle if we decide to work on it.

apricote avatar Mar 12 '24 08:03 apricote

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

github-actions[bot] avatar Aug 21 '24 12:08 github-actions[bot]