adeptRL icon indicating copy to clipboard operation
adeptRL copied to clipboard

Bug and/or dead code in modular_network.py?

Open sflc6 opened this issue 4 years ago • 1 comments

In particular, see here: https://github.com/heronsystems/adeptRL/blob/2d8b0d3be9d0530f0df55d7f4b919177f8767388/adept/network/modular_network.py#L216-L238

In the following if-statement:

if dim in head_submodules:
    continue

type(dim) == int; however, keys of head_submodules are guaranteed to be str due to the line head_submodules[str(dim)] = submod. This suggests that the above if-statement will never continue. Thoughts on this?

sflc6 avatar May 21 '20 16:05 sflc6

Perhaps we want dim = str(len(shape)) on line 220?

sflc6 avatar May 21 '20 16:05 sflc6