identity icon indicating copy to clipboard operation
identity copied to clipboard

Request to /oauth/authorizations can return an unexpected 206 status

Open dmcinnes opened this issue 9 years ago • 1 comments

https://github.com/heroku/identity/blob/master/lib/identity/helpers/auth.rb#L37-L38

If a user tries to connect to an untrusted client but has more than 1000 tokens (a recent problem because our cleaner was backed up) the call to GET /oauth/authorizations returns a 206 response, causing a 500 in Identity. We shouldn't just add it to the expects array, because the token we seek might exist in the remaining auths, probably we should iterate over the range.

dmcinnes avatar Apr 22 '15 00:04 dmcinnes

Doh! This one is really embarrassing. We can't even get our own pagination right ;) +1 and thanks for logging this.

brandur avatar Apr 22 '15 04:04 brandur