Add support for specifying a custom key to be added to the trusted keys

[amiel]

This should resolve #33

Add a key with the following format:

:key:name:url

For example:

:key:nginx:https://nginx.org/keys/nginx_signing.key
:key:confluent:http://packages.confluent.io/deb/4.1/archive.key

I tested this with the following Aptfile (this is @catkhuu's example and the package I got stuck on without having a key):

:key:nginx:https://nginx.org/keys/nginx_signing.key
:repo:deb http://nginx.org/packages/ubuntu/ xenial nginx
nginx-nr-agent
:key:confluent:http://packages.confluent.io/deb/4.1/archive.key
:repo:deb [arch=amd64] http://packages.confluent.io/deb/4.0 stable main
confluent-kafka-2.11
confluent-schema-registry

[amiel]

I'm not sure if the tests will pass without resolving https://github.com/heroku/heroku-buildpack-apt/issues/16.

[kiranpraneeth]

Thanks for fixing this. Do we plan to merge it soon into master? I am using amiels repo for now

[ckhall]

any news on a merge into master?

[dursk]

This has been open for over a year, are there plans to merge it? I'm using amiel's repo for now as well.

[benpbolton]

This has been open for over two years now; I'm using amiel's repo as well eg.

https://github.com/heroku/heroku-buildpack-apt/issues/33#issuecomment-433245494

[granth]

I resolved the conflicts in my fork: https://github.com/4ormat/heroku-buildpack-apt/tree/keys

buildpack: https://github.com/4ormat/heroku-buildpack-apt#keys

[adamchainz]

I'd also like to see this. I've re-resolved the conflicts with the latest master in this fork: https://github.com/elkrange/heroku-buildpack-apt/commit/6cb682208dd8bb41b790cea9f761d22f0d4dc561 (the only conflict was around the context with the if for adding repos).

[dentarg]

@edmorley do you think there's a chance this would be accepted if conflicts were resolved?

[edmorley]

@dentarg Hi! I'm not against the idea of adding support for this (it seems useful), however:

• this buildpack's testing story is pretty lacking, which makes any change high risk
• this buildpack isn't really owned by any team (it's an "unofficial" buildpack sadly, even though IMO it's an important buildpack)
• focus at the moment is on Cloud Native Buildpacks (https://buildpacks.io) which would eventually make this buildpack redundant

[amiel]

Ok, I've pushed an updated branch, so this should be mergeable. Thanks to @granth for dealing with the conflicts, although I have not tested the conflict-resolved version. Is someone actively using this that could test it?

[bf4]

@schneems @edmorley any chance we can find a way to get this (or something like it) live? maybe an opt-in experimental feature?

e.g. I wanted to install tailscale and wanted to configure

:repo:deb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/ubuntu jammy main # HEROKU_STACK
tailscale