heroku-apps icon indicating copy to clipboard operation
heroku-apps copied to clipboard

heroku buildpacks output colour makes text impossible to read

Open edmorley opened this issue 7 years ago • 1 comments

After running a heroku buildpacks:{add,remove} foo command, the new list of buildpacks printed displays fine. However if I run just heroku buildpacks the buildpacks list is the same colour as the terminal background.

Either commenting out the cli.styledHeader() call here: https://github.com/heroku/heroku-apps/blob/12fe59bc65f9a2ca1aada86fe5c6d9fa9ec589a8/src/commands/buildpacks/index.js#L14

Or replacing the cli.color.dim() and cli.color.bold()calls here: https://github.com/heroku/heroku-cli-util/blob/1e6da98444ddde1a8fcd5a28d73f820ab575405d/lib/styled.js#L38

...makes the text visible again - which makes me think it's an issue with the colour reset.

Digging around found chalk/chalk#145, however that seems to be affecting Bash on Windows which I'm not using. Even if it's a Windows or Chalk bug, perhaps it's worth not using dim/bold in too many places for now, and sticking just to colours (which work fine)?

This was using: heroku-cli/6.12.8-ec1843e (windows-x64) node-v8.1.4 ConEmu build 170517 MSYS2 Windows 10 Pro x64 build 15063.483

Screenshot: heroku-buildpacks-colour-bug

edmorley avatar Jul 15 '17 01:07 edmorley