cli-engine icon indicating copy to clipboard operation
cli-engine copied to clipboard

Published 20 hours ago • verified publisher icon heroku

performance

Open jdx opened this issue 7 years ago • 3 comments

v6 seems to be 100ms slower with heroku auth:token (a command that doesn't hit the API) we should do some perf work to find out why, possibly using time-require

jdx avatar May 09 '17 18:05 jdx

Results on time-require on heroku-status (v6 branch): https://gist.github.com/dickeyxxx/e871ec4b8e8a4c225b660571695e49c1

jdx avatar Jun 02 '17 16:06 jdx

a big source of these is from log-chopper because it has its own version of fs-extra and fs-extra is apparently pretty heavy. @RasPhilCo I added https://github.com/RasPhilCo/log-chopper/pull/3 to make this better

jdx avatar Jun 02 '17 19:06 jdx

I also fixed the klaw filter for linked plugins that was slowing down linked plugins severely https://github.com/heroku/cli-engine/commit/85f9dc9978f3ae5841f537e0f24e2028ce78c14d

jdx avatar Jun 02 '17 19:06 jdx