buildpacks-nodejs icon indicating copy to clipboard operation
buildpacks-nodejs copied to clipboard

Update resolve_version to support both inventory formats

Open mlarraz opened this issue 1 year ago • 2 comments

First step at addressing https://github.com/heroku/buildpacks-nodejs/issues/938

This preserves the existing script's behavior while also allowing it to read the newer Inventory format from heroku_inventory_utils as used in https://github.com/heroku/buildpacks-nodejs/blob/main/buildpacks/nodejs-engine/src/main.rs.

I also added a more detailed error message for when no resolution is found, listing the requirements as well as target OS and arch.

mlarraz avatar Oct 17 '24 20:10 mlarraz

Updated to incorporate changes from https://github.com/heroku/buildpacks-nodejs/pull/926

mlarraz avatar Nov 12 '24 21:11 mlarraz

Going to mark this as a draft for now due to the reasons mentioned in https://github.com/heroku/heroku-buildpack-nodejs/pull/1321#issuecomment-2688044634. Will need to revisit at a later date but, for now, there is no bandwidth for these changes.

colincasey avatar Feb 28 '25 17:02 colincasey

Closing this as unplanned.

colincasey avatar Aug 06 '25 14:08 colincasey