Need hot reloading of lua modules.

[madclaws]

Description

Whenever we make a change in lua modules.The changes should be effective onspot rather than restarting server.

[mindfulme]

yep, we want something like "nodemon" but for your server

[mindfulme]

Because it is really inconvenient when you have to reload your docker container each time (in case you're not running it locally)

[mindfulme]

or at least it will be fine if you guys will make a hot reload for docker

[BehroozBahrameh]

an endpoint like /-/reload in Prometheus and alert manager .

[selimanac]

+1

[nomi27951]

+1 Sir

[mrpuzzler]

+1

[emircanerkul]

+1

Otherwise really hard to develop and debug.

[Mohsen7s]

Beside this feature it's easy to implement, its a must have. It's really annoying restart whole docker containers just to reload a module. +1

[shayneoneill]

+1 Would be good, even if just as a debug option (I realise it gets hairy across clusters, but dev is usually on single node servers)

[majstorki88]

+1, and is there any plans for this? This remains open from 2018? Same situation for multiple clusters...

[novabyte]

@majstorki88 It remains open because it's a very complex task. To introduce hot reloading within a running Nakama cluster is akin to code reloading as handled by the Erlang runtime. Pull requests are always welcome 🙏

[deflinhec]

#965

[emircanerkul]

@deflinhec if it's done and tested could you please close this issue?

[deflinhec]

It's done with final PR #966. I've tested with some of my scripts.

It would be great if someone else can test it also, just for making sure this feature works as expect.

@emircanerkul I don't think I have the permission to close this issue.

[dragonlobster]

+1 does it also work with typescript modules/go modules

[deflinhec]

I'd create a PR for lua hot reload, for runtime match and rpc. Not so sure about how typescript perform a hot reload.

[deflinhec]

In the earlier PR I didn't handle lua hot reload properly. It only affect to rpc runtime and matches which creates after the hot reload. The newer PR now takes effect to preexisting runtime rpc and matches.