NESS-Reloaded icon indicating copy to clipboard operation
NESS-Reloaded copied to clipboard
verified publisher icon herobrine99dan

General code cleanup

Open A248 opened this issue 5 years ago • 5 comments

  • ~~Remove unused imports~~
  • ~~Remove remaining reliance on NESSAnticheat.getInstance()~~
  • ~~Deprecated and replace calls to ReflectionUtility with better practices including caching Field and Method instances.~~
  • Do much, much less inside the constructor of MovementValues (Working on)
  • ~~Avoid public fields in MovementValues~~
  • Use proper visibility on all fields
  • ~~Either remove or recode and un-deprecate NoSlowBow and NoSlowFood, which are noted as needing a complete recode.~~
  • Add @Override in a few places where it was for some reason omitted.

A248 avatar Oct 03 '20 01:10 A248

Remove remaining reliance on NESSAnticheat.getInstance() = Done

herobrine99dan avatar Nov 09 '20 08:11 herobrine99dan

Remove remaining reliance on NESSAnticheat.getInstance() = Done? Avoid public fields in MovementValues = Done?

herobrine99dan avatar Dec 11 '20 08:12 herobrine99dan

https://github.com/herobrine99dan/NESS-Reloaded/commit/079074c02efff1a36eff200bc5a97ff9e6ebba17 https://github.com/herobrine99dan/NESS-Reloaded/commit/1d62a88ffe4ea84c8e77cf5f035a0a745e89c0b3 https://github.com/herobrine99dan/NESS-Reloaded/commit/dbfb674f4550c81ed7ae4c1dd351091588cd3a31 https://github.com/herobrine99dan/NESS-Reloaded/commit/d4765ef1b5e0c46138ca16544d5c584622b20838 https://github.com/herobrine99dan/NESS-Reloaded/commit/2855bdc07507e43a1cac9ef9882bb743ace2b145

A248 avatar Dec 11 '20 13:12 A248

Remove static methods from Utility class

herobrine99dan avatar Dec 13 '20 21:12 herobrine99dan

  • ~Remove unused imports~
  • ~Remove remaining reliance on NESSAnticheat.getInstance()~
  • Deprecated and replace calls to ReflectionUtility with better practices including caching Field and Method instances.
  • Do much, much less inside the constructor of MovementValues
  • ~Avoid public fields in MovementValues~
  • Use proper visibility on all fields
  • ~Either remove or recode and un-deprecate NoSlowBow and NoSlowFood, which are noted as needing a complete recode.~
  • Add @override in a few places where it was for some reason omitted. Deprecated and replace calls to ReflectionUtility with better practices including caching Field and Method instances. = done

herobrine99dan avatar Mar 23 '21 12:03 herobrine99dan