hernanmarino

Results 29 comments of hernanmarino

Fixed the last nit: Pushed to remove the extra space mentioned by @fjahr https://github.com/bitcoin/bitcoin/compare/da13cc2c8010cbccf37324cca4403cb346ecdd30..8d20602e555dfe026b421363ee32cfca17c674d8

> You'll have to remove the TODO on the top of the file as well, when the test was added? Done. It'll be updated with my next push

> Are you still working on this? I haven´t been able to think of / work on other tests to add, but the current commit test is ready for review,...

Updated to remove a (no lonnger valid) TODO comment as requested in https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-1952480346. Also updated the PR title and description.

> Please delete the hidden comment in the pull description, because this will end up in the merge commit. Oh, sorry for that. Deleted.

Updated to re add an incorrectly removed TODO comment.

> Needs rebase (for some reason Drahtbot isn't detecting this) Rebased. Also deleted a couple of redundant comment as suggested by @maflcko to retrigger the false negative CI

This might fix issue https://github.com/esneider/indy/issues/3 if the user is using a different version of connectrum due to inability to install the one referenced in `requirements.txt`

ACK to the idea of removing overflows in the code, but I was little worried of the implications of this. After reading @sipa 's comment, it is definitely an ACK...