hernanmarino

Results 29 comments of hernanmarino

I agree with @achow101 I believe this should be done earlier.

> Thanks for testing! @hernanmarino could you post the warnings, and maybe post your compiler version? I don't think I'm seeing these and I don't think they are happening on...

Hi @RandyMcMillan . Thank you for taking the time to look at my PR. The changes I implemented are actually on `bitcoin-qt` and not on `bitcoin-cli` . I updated the...

Thanks for all the insights. In the first days of the next week I'll try to incorporate the feedback and squash the commits.

Thanks for the feedback and testing. I ' m already working on an update consider this and all feedback received, will update soon. > @hernanmarino - @rserranon 's suggestion is...

Summary of changes just pushed: - Changed the regex for a simpler string splitter, while still mantaining the syntax and several argument separators (beyond whitespace) supported by the console. Code...

> Noticed that we are calling cli-only commands with the "-" prefix. Would be good to follow the same convention here too. The renaming will let us detect them in...

> I agree with furszy's idea of introducing the functions `IsCliOnlyCommand ` and `ExecuteCliCommand `, to implement the `generate` cli-only command, for a cleaner implementation and with the advantage of...

> Could this PR be separated in two commits: > > * refactoring and introducing the `RPCExecutor::executeConsoleOnlyCommand()` function > * actually adding support for the `generate` command` > > ?...

As requested by @hebasto i splitted this PR in 2 commits : ad5642ae91beb522b6ae806f28cb015a759d1d19 refactors the code to prepare for the new functionality implemented in the following commit, as well as...