uhyve icon indicating copy to clipboard operation
uhyve copied to clipboard

Published 20 hours ago • verified publisher icon hermit-os

Don't treat `hlt` as a shutdown command

Open jounathaen opened this issue 4 years ago • 3 comments

Treating hlt like a shutdown is a nice hack, but might lead to problems. I think it's better to continue execution after the instruction.

jounathaen avatar May 06 '20 15:05 jounathaen

Doesn't the patch hermitcore/libhermit-rs#45 solve this issue?

stlankes avatar May 11 '20 18:05 stlankes

No, it just ensures that the hlt instruction is not called on shutdown. I think the behaviour of uhyve is still wrong. I'm not sure what the correct behaviour would be, though.

jounathaen avatar May 12 '20 08:05 jounathaen

PR #14 is workaround because hlt is only used in the idle loop.

stlankes avatar May 14 '20 20:05 stlankes