kernel icon indicating copy to clipboard operation
kernel copied to clipboard

Resolve the rusty-hermit name clash

Open jounathaen opened this issue 4 years ago • 4 comments

Current Situation:

The naming of the repositories and the crates is contradictory.

Crate Name Repository Name Task
rusty-hermit https://github.com/hermitcore/libhermit-rs The Kernel itself
hermit-sys https://github.com/hermitcore/rusty-hermit FFI - What is actually imported in the applications. libhermit-rs is downloaded and linked in the magic build.rs script

Problems

  • Public resources like papers etc link to https://github.com/hermitcore/libhermit-rs, so the URL always has to point to the "Cenral" repository.
  • crates.io links to https://github.com/hermitcore/rusty-hermit. I don't know if the links there could be changed retrospectively.

Solution Attempts

These are the two solutions I came up with

Rename the Repository Attempt

  • Move the content of https://github.com/hermitcore/rusty-hermit to a differently named repository.
  • Update crates.io to the new location
  • Move this repository to the now free rusty-hermit url. This implies breakage

Rename this Crate Attempt

  • change the name of this crate to libhermit-rs
  • update the crate name in hermit-sys/hermit-loader/...

jounathaen avatar Apr 28 '20 18:04 jounathaen

Another Solution Attempt:

Merge Everything Attempt

  • Put libhermit-rs into the rusty-hermit repository (not as a submodule)
  • Leave a link to rusty-hermit at this repository

jounathaen avatar May 05 '20 14:05 jounathaen

Do we solve the issue? I think that #77 describes the remaining problem.

stlankes avatar Jun 03 '20 16:06 stlankes

Ah, the remaining problem I almost forgot about is, that the crate names are still mixed up

jounathaen avatar Jun 17 '20 18:06 jounathaen

@jounathaen, do you feel like the "Rename this Crate Attempt" has been successful in https://github.com/hermitcore/libhermit-rs/pull/505 so that this issue can be closed?

mkroening avatar Jul 28 '22 22:07 mkroening

Yes, this is resolved now! :partying_face:

jounathaen avatar Nov 02 '22 22:11 jounathaen

There are still places left where we link to libhermit-rs using the name RustyHermit, like in the loader Readme. We should have another word on this, and perhaps adopt the name Hermit (without Rusty) in more places, where we are not specific to Rust userspace.

mkroening avatar Nov 17 '22 17:11 mkroening