grf-extractor icon indicating copy to clipboard operation
grf-extractor copied to clipboard

can't extract with korean language

Open gandhyonly opened this issue 8 years ago • 6 comments

even if I have korean grf after I extract it will be ascii grf can you fix it?

gandhyonly avatar Dec 30 '16 06:12 gandhyonly

It should be unicode (utf-8)? Are the names incorrect or the file contents?

I'm not sure we touch the file contents (we export the binary file as is from the grf), but the file name may be being corrupted, I could check that.

herenow avatar Dec 30 '16 19:12 herenow

did you know how to make it utf-8? I already extract it to your binary lang but it works fine.. I think that binary language have same mean with korean language.. but I need korean language because its more readable. I see your source code but I never to set something like korean language too. so I don't know how to fix it.. and If I know I will learn all your code before doing it T.T

your source code just about extract right? did you know how to repack it to be .grf?

gandhyonly avatar Jan 01 '17 15:01 gandhyonly

Yep, this package only extracts files from grf.

Are you extracting from linux or windows (although I'm not sure this matters).

I believe you are having problems with the file names, right? When you open the file, the encoding is correct (assuming your text editor has the right encoding set)?

Currently, when we parse the file name from the grf, here:

https://github.com/herenow/grf-extractor/blob/master/lib/Loaders/GameFile.js#L196

We are reading byte by byte, and translating each byte to an ascii character, so we don't support unicode/utf-8.

I could try to write a fix for this this week, if you are willing to test this out :)

herenow avatar Jan 02 '17 05:01 herenow

wow I really want to test it out.. is there a way to repack it too? so my plan is I want to create automatic website for custom grf :D then I need your script to repack automatically..

but I guess we can't do that.. there's so much work to make it grf repack hahaha..

thanks anyway :)

gandhyonly avatar Jan 06 '17 13:01 gandhyonly

The text encoding of the file names is not UTF-8, it is EUC-KR.

cmbasnett avatar Feb 21 '20 03:02 cmbasnett

Apologies, it's actually CP949!

cmbasnett avatar Feb 23 '20 02:02 cmbasnett