here-data-sdk-cpp icon indicating copy to clipboard operation
here-data-sdk-cpp copied to clipboard

Fix compilation of AlignedBox

Open VeaaC opened this issue 1 year ago • 3 comments

Not all template functions were actually compiling, and no test ever instantiated the classes fully.

VeaaC avatar Sep 25 '24 13:09 VeaaC

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.42%. Comparing base (17f6a68) to head (0620854). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
- Coverage   81.44%   81.42%   -0.02%     
==========================================
  Files         345      345              
  Lines       13537    13538       +1     
  Branches     1457     1458       +1     
==========================================
- Hits        11025    11023       -2     
- Misses       1922     1924       +2     
- Partials      590      591       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 25 '24 14:09 codecov[bot]

Please update the commit message:

  • Split long lines (we follow 50/72 rule)
  • Add Resolves or Relates-To

andrey-kashcheev avatar Sep 25 '24 14:09 andrey-kashcheev

@andrey-kashcheev what is the Resolves/Relates to about? There is no issue for this / other repo / etc?

VeaaC avatar Sep 25 '24 14:09 VeaaC

Done @andrey-kashcheev

VeaaC avatar Sep 26 '24 06:09 VeaaC