Alastair Maw

Results 29 comments of Alastair Maw

This is because it is [only submitted on the blur event](https://github.com/jitsi/jitsi-meet-electron/blob/eb95561b576d3420f98710e3fd315bb9858a24d0/app/features/settings/components/ServerURLField.js#L84), which I guess isn't happening when you hit the back arrow, for whatever reason. Suggested fix: Update it onChange...

> a bare string is not valid JSON That is true if you look at json.org, but has been superseded in 2014 by [RFC-7159](https://tools.ietf.org/html/rfc7159) and [ECMA-404](http://www.ecma-international.org/publications/standards/Ecma-404.htm). From RFC-7159: > Note...

FWIW `https://api.polygon.io/v3/reference/tickers?market=stocks&ticker=YHOO&date=2010-07-23&apiKey=*` has `YHOO`, but without the `primary_exchange` set (which is why your filtered view is missing it).

This data is still missing, 9 months after this bug report. Any chance of fixing this?

Looks like a duplicate of #305 (am also running into this).

> `TimeoutAttribute` is marked `Obsolete` for .NET Core builds. Test Code should be upgraded to use the `CancelAfterAttribute` instead. That's all very well, but you can't set it at an...

This is breaking default protobuf generated code type checking which is a shame. (See mentioned issues above.) Would be lovely to get this sorted out. 👍🏻

That is obviously for you as project maintainers to decide, but fwiw I've moved much larger codebases over to ruff and found it to be 100% Flake8/isort/Black-compatible, just a lot...

You're very welcome. https://github.com/astral-sh/ruff/blob/main/docs/formatter.md#philosophy might help you get over that: > The initial goal of the Ruff formatter is not to innovate on code style, but rather, to innovate on...

While I agree you could do that, surely you want the other pre-commit checks to run on GitHub anyway? We run with this exact set-up and find it works well,...