snapdragon icon indicating copy to clipboard operation
snapdragon copied to clipboard

Please upgrade source-map to 0.7.2 to get speed improvements

Open andreicristianpetcu opened this issue 7 years ago • 3 comments

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072 http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/ https://github.com/devtools-html/debugger.html/issues/5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

andreicristianpetcu avatar Mar 04 '18 15:03 andreicristianpetcu

it's in the pipeline, thanks

jonschlinkert avatar Apr 09 '18 23:04 jonschlinkert

Only problem with this is that source-map dropped support for node <8 in this version.

danez avatar Apr 10 '18 06:04 danez

I'd like to externalize source maps completely. Perhaps instead of options.sourcemap being a boolean, we can allow the user to pass a function - which could be snapdragon-sourcemaps or a custom function.

Thoughts?

jonschlinkert avatar Apr 10 '18 07:04 jonschlinkert