augeas icon indicating copy to clipboard operation
augeas copied to clipboard

NetworkManager new values are added using double quotes

Open teclator opened this issue 3 years ago • 2 comments

Apparently since this change https://github.com/hercules-team/augeas/commit/bf25803ba4b3aa4e81feefb8fc217753ab6005c4 new entries are added using double quotes which NetworkManager does not seem to support.

Editing an entry works fine but it is not the case of new entries:

$ sudo augtool set /files/etc/NetworkManager/system-connections/enp0s25.nmconnection/ipv4/dns "8.8.8.8;8.8.4.4"
Saved 1 file(s)

$ cat /etc/NetworkManager/system-connections/enp0s25.nmconnection | grep ^dns=
dns="8.8.8.8;8.8.4.4"

$ cat /etc/NetworkManager/system-connections/enp0s25.nmconnection | grep ^method
method=auto
method=auto

$ sudo augtool rm /files/etc/NetworkManager/system-connections/enp0s25.nmconnection/ipv4/method
rm : /files/etc/NetworkManager/system-connections/enp0s25.nmconnection/ipv4/method 1
Saved 1 file(s)

$ sudo augtool set /files/etc/NetworkManager/system-connections/enp0s25.nmconnection/ipv4/method auto
Saved 1 file(s)

$ sudo augtool set /files/etc/NetworkManager/system-connections/enp0s25.nmconnection/ipv6/method manual
Saved 1 file(s)

$ cat /etc/NetworkManager/system-connections/enp0s25.nmconnection | grep ^method
method="auto" 
method=manual

And from the journal logs we can see:


<warn>  [1617622626.9161] keyfile: ipv4.dns: ignoring invalid DNS server IPv4 address '"8.8.8.8'
<warn>  [1617622626.9161] keyfile: ipv4.dns: ignoring invalid DNS server IPv4 address '8.8.4.4"'
<warn>  [1617622626.9162] settings: load: failure to load "/etc/NetworkManager/system-connections/enp0s25.nmconnection": invalid connection: ipv4.method: property is invalid

teclator avatar Apr 05 '21 11:04 teclator

@raphink could you take a look?, we adopted the Desktop lens because of the quotes problem but it has problems when '#' is used in the values that is basically what your commit fixed.

teclator avatar May 03 '21 19:05 teclator

@mchf thnx for taking care!

teclator avatar May 26 '21 13:05 teclator