hercules-ci-agent
hercules-ci-agent copied to clipboard
`hci secret` ignores empty JSON objects
Description
The JSON merging algorithm I wrote is stupid.
Should have been a [Value] -> Value
merge instead of a merge of (path, value) association list.
To Reproduce
hci secret echo --json foo 'true' --json bar {}
{
"kind": "Secret",
"data": {
"foo": true
}
}
bar
is missing.
Expected behavior
hci secret echo --json foo 'true' --json bar {}
{
"kind": "Secret",
"data": {
"foo": true,
"bar": {}
}
}
Platform / Version
hci 0.2.4
Hey @roberth I have fixed this and raised a PR for this. Please review my PR. Thanks!