herbsjs
Herbs generated project must to born with lint
I was thinking to have an option to add esLint into project
> Do you wanna use lint ? [y/N] y
- esLint
- tsLint
- jsHint
> What code style do you prefer to use?
- standard
- google
- airbnb
To start this feature, I was thinking to use only standard code style
Hi! We can start with one of the options. What do you think we started with eslint using the Vortx One Manager config as default. About the google and airbnb options, we can use the configuration of these packages, respectively, https://github.com/google/eslint-config-google and https://www.npmjs.com/package/eslint-config-airbnb .
I like to start with a default linter, but I prefer the standard JS because it's the standard, this style guide is the more neutral, some developer don't like the airbnb style guide or google style guide but I think the most developers will accept the standardJS because it's neutral
As long we choose one and the user don't have to choose, I don't really care. The choice will always be wrong since there will be always someone complaining, so let's pick one.
standard JS sounds ok to me.
Given the inputs on this issue, this is how I think this feature should work:
- Generate and specify the StandardJS by default on lint file
- Add a script action on npm to run lint on everyfile of the project.
- This script to lint all files should run after
herbs new. This is important since the current file templates does not respect any lint or even worse (some are a real mess) and the generated file doesn't look good.
@dalssoft I guess should be good to run the script (like npm run lint or lint:fix) after herbs update as well
https://github.com/herbsjs/todolist-on-herbs/blob/97c541a05c7530c769b772d650db6ff19ec2a94a/package.json#L16