herbs-cli icon indicating copy to clipboard operation
herbs-cli copied to clipboard

Herbs project must to born with Dockerfile

Open italojs opened this issue 4 years ago • 6 comments

I was thinking the herbs-cli could have an option to create the project with an setup config, example

>herbs new
>Do you need a setup config file? [y/N] y
- Make file
- Dockerfile
- Dockerfile + docker-compose
- container engine1
- container engine2

italojs avatar Aug 19 '21 19:08 italojs

When you say 'container engine1' and 'container engine2', do you mean to generate the Kubernetes manifest files?

Example:

 >herbs new
 >Do you need a setup config file? [y/N] y
 - Make file
 - Dockerfile
 - Dockerfile + docker-compose
 - Kubernetes - Pod
 - Kubernetes - Pod + Service

ssmaciel avatar Nov 30 '21 21:11 ssmaciel

it could be an option too

italojs avatar Nov 30 '21 23:11 italojs

@ssmaciel can you take this issue?

jhomarolo avatar Jul 01 '22 15:07 jhomarolo

I'm not convinced we should have this kind of boilerplate on herbs cli given it has no direct relationship with Herbs capabilities

dalssoft avatar Jul 01 '22 15:07 dalssoft

I thought the idea of the cli was to evolve to a place close to a real application.

Since many applications today already use docker and/or kubernetes, the application to come with a preconfigured file would make sense in my opinion.

jhomarolo avatar Jul 01 '22 16:07 jhomarolo

I agree with @jhomarolo! HERBS are for real life and many applications today run in containers. As an option in the CLI, I think it's an interesting improvement.

maikmb avatar Jul 05 '22 14:07 maikmb