bytenode-webpack-plugin icon indicating copy to clipboard operation
bytenode-webpack-plugin copied to clipboard

Add `electron-builder` support

Open JohnnyYeen opened this issue 3 years ago • 2 comments

Hi there, you've done an incredible and exciting job on electron-forge! However, as we can see there're tons of projects built within electron-builder. So are there any plans for electron-builder supporting? Really appreciated!

JohnnyYeen avatar Nov 23 '21 02:11 JohnnyYeen

@JohnnyYeen hello!

This project is not something specific to electron-forge, it's a webpack plugin for bytenode, so you can use it with any project that uses webpack (that being plain node, or electron). electron-forge uses webpack in a very specific way and that's why we had to specifically add extra support for it.

As far as I know electron-builder doesn't require the use of webpack and I don't think electron-builder uses webpack by itself (as electron-forge does), so I believe it's up to you if you want to use both webpack and bytenode-webpack-plugin.

Have you tried to use bytenode-webpack-plugin with electron-builder? If so, can you post some details about your experience and the problems you encountered? Maybe there is a simple fix for the bug you're facing?

And do you have any suggestion on how we may go about improving our currently very simple documentation to better explain the relationship this plugin has with webpack, electron-forge, electron-builder, etc?

Thank you for the appreciation!

herberttn avatar Nov 30 '21 14:11 herberttn

I think it's already supported out of the box, just need to follow the usual pattern in the example repository. I can confirm that this works with electron-builder, great work!

josteph avatar Feb 20 '22 16:02 josteph

Sounds like this is a solved problem. Closing. Please reopen if I'm mistaken.

jjeff avatar Oct 10 '22 15:10 jjeff