mytap icon indicating copy to clipboard operation
mytap copied to clipboard

Published 20 hours ago • verified publisher icon hepabolu

Installer is now able to discover tests

Open sq6jnx opened this issue 5 years ago • 4 comments

When adding tests for #48 I encountered difficulty on adding test file for it. Hence, I decided to add test discoverability for installer.

I'm not sure however how should I rename test files:

  • tests/eq.my → tests/test-mytap-eq.my
  • or maybe tests/test-mytap-event.my → tests/event.my

sq6jnx avatar Oct 27 '19 08:10 sq6jnx

Ready for merge except one fixup commit and question posted in PR description.

Please take a look at this.

sq6jnx avatar Oct 28 '19 08:10 sq6jnx

Any news on this?

sq6jnx avatar Nov 14 '19 12:11 sq6jnx

Sorry for taking such a long time to respond. Re the naming: I'm fine with tests/eq.my → tests/test-mytap-eq.my

hepabolu avatar Aug 13 '20 21:08 hepabolu

If you can fix the conflict, then please go ahead and merge the pull request

hepabolu avatar Aug 13 '20 21:08 hepabolu