Derek Hensley
Derek Hensley
Yeah, most of the renaming come from `clang-tidy` itself, but I did make two intentional changes that I noticed - `void EnItem00_DrawHeartContainer(EnItem00* actor, PlayState* play)` -> `void EnItem00_DrawHeartContainer(EnItem00* this, PlayState*...
Going to draft this. Want to to see what happens with https://github.com/zeldaret/oot/pull/1331 and if we should ~~steal~~, I mean ask nicely if we can use it.
Okay this should be good to go again. Would recommend just trying out the new script if you haven't already.
> Is this PR still waiting for the agents to be updated? I believe we are still waiting on Kenix's agent.
> Jenkins is complaining there are unformatted files, but I can't reproduce the problem locally. Shouldn't this be using a specific clang format version? Hmm, locally I see EnZos change...
Converting to draft again. For some reason Slug is coring when trying to run clang-apply-replacements, and would like to figure that out first.
Undrafted. Looks good again. Thanks Roman.
> > Just a couple minor things. Also if you want Co-Authors to show up properly in Git, they need to have two new lines between them and the commit...
Oh I didn't notice, but if you remove the `-m "Empty-Commit"` option it will give you a text editor that you can use. Also I feel it would be better...
Petrie just found a typo in SkelAnime_InterpFrameTable, where the arg `tactoret` should really be `target` which seems in scope to fix in this PR. Also I just thought of the...