Alice

Results 77 comments of Alice
trafficstars

Hi! Thanks for responding to me on #3624 Unfortunately the reason you stated is not correct - The `name` in my `package.json` is not "solmate" - it's "@uniswap/universal-router" Interestingly we...

@uchihaada see [this comment](https://github.com/NomicFoundation/hardhat/issues/3623#issuecomment-1411222270) for that specific issue

hey @fvictorio ! Just wondering if theres any update here? Still facing this issue 😢

Have you edited the deploy script from `main` at all? The address its trying to deploy to isnt the canonical deploy address that I would expect.

Hey friends! Sorry for the late response here I took a little time off after the announcement! And hey @Joeysantoro ! Thanks so much for contributing to our project 👯...

With respect to the `approve` logic we actually had a PR in to do so #117 that we decided not to merge for now. I can't currently think of a...

@snreynolds anything else you wanna see before we merge?

Things I'd like to see improved - Lots of asserts missing on all `swap` tests - like the amount actually swapped - Helper function to set up a pool, approve...

- Add explicit `settle` testing - Improve dynamic fee tests - currently they dont explicitly make it clear that the fee is changing with asserts