Alice
Alice
You need to run `yarn snapshots`
Sorryyyy each time you merge in main you have to check the `yarn snapshots` in case gas has changed. You did snapshots _then_ merged main so theyre still wrong 😆...
Hi! So sorry for the delay here - I took some time off work. Please could you do the merge conflicts and make sure snapshots are up to date. I'll...
Hey @shuhuiluo ! We're finally going through our final stages of development so are considering all your optimisations now 🙏 sorry for the delay here! Would you mind please merging...
Hi @malik672 the snapshots are showing that there arent any gas improvements from your code changes? Only the bytecode size has changed
We have now made a number of changes for how protocol fees work so this PR is out of date. We are closing this PR in favor of #283
Please can you merge main so we can re-review the gas improvements 🙏
Would you mind also commenting a comparison of the gas of this PR and #276 pls 🙏 That PR seems to have brought down some of our hardhat snapshots too,...
Hey!! We have now changed protocol fee logic in a few ways, and will be changing it further in #547. After 547 is merged we should be done making our...
Hi! Going to close this PR now for a few reasons 1. we have removed hook fees accruing in the contract and instead they are achieved in other methods (#432)...