cob icon indicating copy to clipboard operation
cob copied to clipboard

Fix for changes in urlsplit

Open PhilGrayson opened this issue 2 years ago • 0 comments

urlsplit function was changed to strip ASCII newline and tab characters in https://github.com/python/cpython/pull/25595.

The change causes this plugin to not properly authenticate with S3, since a required newline character is no longer present.

This issue was identified on Amazon Linux 2 Python distribution which backported the change to Python 2. https://alas.aws.amazon.com/AL2/ALAS-2022-1802.html.

PR #13 has a similar fix for this issue.

urlsplit behaviour before the fix.

Python 2.7.18 (default, Jun 10 2021, 00:11:02)
[GCC 7.3.1 20180712 (Red Hat 7.3.1-13)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from urlparse import urlsplit
>>> urlsplit("http://localhost/some-path\n").path
'/some-path\n'
>>>

urlsplit behaviour after the fix.

Python 2.7.18 (default, May 25 2022, 14:30:51)
[GCC 7.3.1 20180712 (Red Hat 7.3.1-15)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from urlparse import urlsplit
>>> urlsplit("http://localhost/some-path\n").path
'/some-path'
>>>

PhilGrayson avatar Jun 15 '22 23:06 PhilGrayson