Henry Martin

Results 22 issues of Henry Martin

Dear Fiona team, thanks for your great work, I appreciate Fiona a lot! ### Expected behavior and actual behavior. I want to read all entries from a geojson file. However,...

bug

Tours store a list of the trips they aggregate in the field "trips". Unfortunately the datatype of this list is not stable when writing+reading it from a postgis database. In...

I think that the way we define staypoints it would make a lot of sense to create locations only based on staypoints that are activities. For this we could include...

enhancement

All of the generators have the option except for the `generate_triplegs` function. If we keep the loop over users it can be easily added [here](https://github.com/mie-lab/trackintel/blob/066ccf8248664038561a5d65874cb8eae3679e85/trackintel/preprocessing/positionfixes.py#L248)

good first issue

If the tracking quality is bad and all staypoints are pre-filtered, then the variable `method_val` does not get the column purpose and therefore [the line 74](https://github.com/mie-lab/trackintel/blob/master/trackintel/analysis/location_identification.py#L74) raises a key error....

The index of a dataframe plays a very important role in trackintel. Therefore, we included a warning if no explicit index column is provided and the default index is assumed...

enhancement
postgis

The error can be reproduced by setting the chunksize argument in any of the `test_read` tests in `test_postgis` e.g., [here](https://github.com/mie-lab/trackintel/blob/a25c8bcc7fd0b78915dad09d329fc3a1e637583b/tests/io/test_postgis.py#L354) The problem seems to be that `gpd.GeoDataFrame.from_postgis` returns a generator...

bug
postgis

As mentioned in #396 I am getting more and more errors that are linked to trackintel being installed with incompatible versions of its dependencies. A recent example: Since PR #404...

The `tours.as_tours` check fails after generating tours using the `generate_tours` function. This can be easily reproduced by adding `tours.as_tours` at the end of any test case of the tour generation....

bug

Calculating distances on a large dataset is an expensive operation, especially if we need to use the function [calculate_haversine_length](https://github.com/mie-lab/trackintel/blob/master/trackintel/geogr/distances.py#L235). This function is used by several functions ([`calculate_modal_split`](https://github.com/mie-lab/trackintel/blob/0a215cd3d214045292dbd2b77d2af5b3b1df924c/trackintel/analysis/modal_split.py#L7), [`predict_transport_mode`](https://github.com/mie-lab/trackintel/blob/1ff2323c868cfb82c0d0497cf57281c821e044d1/trackintel/analysis/labelling.py#L48)) and additionally...