Henry Schreiner

Results 2513 comments of Henry Schreiner

`h[...,[0, 2], ...]` would probably need (or be best with) support in Boost.Histogram, see https://github.com/scikit-hep/boost-histogram/issues/296. @HDembinski, is this something that can be supported upstream? If we have to, we can...

PS: The issue that got opened and fixed in Boost.Histogram was for slicing on categorical axes, which enabled `h[..., 0:2, ...]` to work, but not selecting a subset of a...

> Seems like a nice feature for boost-histogram. boost-histogram doesn't have named axes, so it wouldn't be as pretty, and would need another layer of wrapping in Hist anyway, just...

> numpy seems to support this, but then seems to adjust bin edges: Ah, good, we could do the same thing. FYI, `Regular(N, 0, 0)` is not valid, since we...

I can help with type annotations and setting up ROOT in the tests. I'll review soon.

Did you test this implementation by hand? Static typing revealed `h.axes()[...]`, which is invalid - axes is a tuple, which can't be called. That's an easy fix, but then I...

Also, please always make a new branch for making a PR. It's a bit more irritating to have to write `git push [email protected]:slehti/hist.git HEAD:main` than it is to just to...

A general point: we should split up PyROOT and coffea conversion. Most users will be converting PyROOT and won't care about coffea. I'll also have to look at coffea a...

Is this from FreeBSD or pip? Maybe, if it’s a FreeBSD package, they forgot to generate the version.py with setuptools-scm.

Ahh, is this the latest `main` (31 commits past 2.6.1)? I think we are accidentally missing the version.py file due to it being in the `.gitignore`. Edit: no, that's not...