Henry Schreiner
Henry Schreiner
Can this be closed or is there an action that should still be taken?
Very strange! I’ll try to look at it soon (possibly after PyCon).
https://github.com/boostorg/histogram/pull/351 is adding this for division to Boost.Histogram. We try to match Boost.Histogram's support here, so division will be added once that is merged.
And the tracking issue for the rest of them is here: https://github.com/boostorg/histogram/issues/352 We'll follow those as they go in, and include them here.
Yep, if it's in Boost.Histogram, it can be added to boost-histogram.
Is there an integration test somewhere (maybe I’m just missing it)? I see unit tests for pieces, but is there a test were a histogram with the new accumulator is...
> Do you mean the user guide? Yes. Not at all a blocker, can be added later, just should be on a todo list somewhere.
Looks great. Boost-histogram doesn't actually use std::vector (except for strings), so I think we'll be fine there.
This is discussed in boostorg/histogram somewhere, such as https://github.com/boostorg/histogram/issues/336. It's really an issue there, rather than here. The algorithm for computing edges has different numerical precision issues than the one...
Can this be rebased on top of current develop?