Henry Schreiner

Results 2507 comments of Henry Schreiner

Any ideas about the failure here in pybind11's CMake build: https://github.com/pybind/pybind11/actions/runs/15433117235/job/43434485966?pr=5714 ``` FAILED: cross_module_interleaved_error_already_set.cpython-313-x86_64-linux-android.so : && /usr/local/lib/android/sdk/ndk/27.2.12479018/toolchains/llvm/prebuilt/linux-x86_64/bin/x86_64-linux-android21-clang++ -fPIC -D__BIONIC_NO_PAGE_SIZE_MACRO -I/tmp/cibw-run-3oae3atu/cp313-android_x86_64/python/prefix/include -DNDEBUG -O3 -Wall -O3 -DNDEBUG -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,-z,max-page-size=16384 -Wl,--no-undefined -lm...

Is `xbuild-tools` not used/needed on Android? (I know we also don't use it currently for pyodide)

(I see you've been using merge commits, so I forced myself to merge with main instead of rebasing on it... I needed the recent changes in main to test the...

@freakboy3742 I rerequeted a review from you since it's still "requesting changes".

reuse_venv is actually a valid `nox.options` value. You are correct, though, that any invalid assignment is ignored - this has bugged me before. I've opened a PR. In your case,...

The function was actually added to make loading PEP 723 files easier, since it's a pretty trivial wrapper over tomllib/tomli otherwise. But defaulting to pyprojec.toml doesn't seem unreasonable.

I wonder if we should just bite the bullet and provide a `--extension-suffix` flag on `pybind11-config`?

Still seems to be broken: https://github.com/scikit-hep/boost-histogram/pull/1020 (edit: I'm going to manually work around it in that PR, failing log at https://github.com/scikit-hep/boost-histogram/actions/runs/15483452068/job/43593373177?pr=1020) ``` + pip install cloudpickle 'hypothesis>=6.0; sys_platform != "ios"'...

I'll see if I can retry this without the workaround after releasing a patch release.