Henry Schreiner

Results 2521 comments of Henry Schreiner

(I'm not an expert on Windows setup, @thewtex or @jcfr might know more). I don't think there's something we are missing that would make it easier on our end, but...

The warning about the libraries can be ignored. Manylinux doesn't contain the Python libraries, since you aren't supposed to link to them and it saves space to delete them. The...

Actually the docs do include the correct way to refer to this in a callout with a warning about manylinux, and the reason the "wrong" version is shown is due...

Fixing that in https://github.com/pybind/pybind11/pull/4805, thanks! I think most users either just use the default FindPythonInterp (bad), or call FindPython first (I hope).

We don’t use `.gitignore` for the wheel. We use it for the SDist. Gitignore is a file for describing what is considered part of the source. An SDist is nearly...

Not yet, but probably soon. At the moment, the model is to describe the difference between SDist & vcs, which is usually at most a few lines. A proper ignore...

I believe this is only an issue because you are using bash for Windows. I think it does the right thing on a Windows shell (the default).

Different shells on GHA have different environments. Only the normal shell has the MSVC setup, the bash one does not. It doesn't matter what cibuildwheel uses, the environment setup is...

See https://github.com/pypa/cibuildwheel/issues/1338 which is why we changed this in cibuildwheel to using powershell on Windows.

No, GitHub Actions sets up the correct MSVC for you for both archetectures, but only for Powershell (and probably CMD). If you run msvc-dev-cmd, then that sets up just what...