Henry Schreiner

Results 2521 comments of Henry Schreiner

I think #371 might be needed to fix those last three tests. I just need to figure out why there's sometimes an unfinished process in that PR.

I'm going to slip this in the next patch release, since a minor release won't be for a bit, and I want to get a patch release out now that...

We do want to get the same compiler setuptools would get if things is specified. If you set up your shell with x86 (by clicking on the "x86 command line"...

Tox isolates you from the surrounding environment variables by default. Nox does not, by the way. You can set a tox config to pass through environment variables. That’s my first...

The `pep518` tests are specifically testing the ability to do isolated builds, which downloads packages from PyPI. You can disable them with `-m “not network”`. There are matching `pep517` tests...

I think this is a good idea, though the second example of the first one isn't necessary, you can set `editable.rebuild` without overrides and it will only affect editable builds....

We might be able to use the skbuild stage (https://scikit-build-core.readthedocs.io/en/latest/cmakelists.html#accessing-information) instead of just editable true/false. Would have to think about it a bit more, but I think it would be...

A quick comment: Yes, the process is different between Windows and Unix. Specifically, it's actually based on the generator - multi-config generators (default on Windows) have the flags you are...

I see `-DCMAKE_BUILD_TYPE:STRING=Debug` in the configure line for Unix in your logs. It seems to be filtering it from `CMAKE_ARGS` and setting it in the configure step, as is correct...

Where are you linking to the RavenHydroFramework library or including that in your build? I see you adding that to an executable, but not to the Python target. `ExitGracefully` is...