Henry Schreiner

Results 2524 comments of Henry Schreiner

FYI, see https://github.com/scikit-build/scikit-build/pull/731 - A build backend can specify dynamic dependencies; scikit-build-core will probably do this do only add `cmake` and/or `ninja` if they are not present on the system...

Mesonpy should list ninja using the requires for build wheel hook and only include it if it's not already installed. CC @FFY00. https://github.com/FFY00/meson-python/blob/1a4882e9f6d973934185a0f5fec052750983b960/mesonpy/__init__.py#L965 Should have something like this: ```python ninja...

> I disagree with this approach. Listing requirements should not be impure, that is, depend on the actual build machine. The _actual_ requirement is not a python package. It's the...

A compiled build system in python is never pure. You’re calling a compiler with ninja. We don’t pip install GCC or Clang. Your proposed dummy package would not be pure,...

> I proposed that @FRidh could solve distro integration concerns by performing third-party patching upon this repository I think that was what the issue was about originally, though I read...

Do you know what the minimum version of ninja required for meson? I can make a PR to meson-python that fixes this to show what I mean.

Thanks! Turns out it's 1.8.2, nicely listed in the Meson error message. :) (though maybe that's a more recent version - guessing this should track whatever's required in the latest...

> I'm ambivalent to whether installing the "ninja" sdist should detect a system ninja and declare that version but not install it, There's no way for the ninja 1.10.2.4 SDist...

Then don't install the ninja package system-wide. `pip install ninja==1.11.0.` should install 1.11.0 (with the added jobserver support), not do nothing if ninja (especially not exactly equal to 1.11.0) is...

I think you meant to submit this to upstream; this is just a PyPI redistribution of ninja and we don't have a `configure.py`.