Henry Schreiner

Results 2507 comments of Henry Schreiner

> pip-compile --output-file=requirements.txt requirements.in This didn't do anything at all - the requirements.txt satisfied the requirements.in. I do see where you are thinking about a "change only what is required",...

`requirements.in`: ``` numpy ``` Currently, there is no way to `pip-compile` this file and get something broken. 2.7 will give you numpy 1.16, 3.8 will give you numpy 1.21. If...

> . If you ever run into such a problem Currently, it's not a problem, because setting a minimum Python version doesn't break things - a tremendous amount of work...

I'm sorry, I didn't mean to come off as argumentative. I was just responding to the fact that you were addressing my concern with "I don't need that in my...

PS. I have no say in the final decision, design, etc. of this, which is why I'm trying to make my worries known. I think the initial description doesn't make...

Nice, I think this is the first scikit-build package to be included. You aren't trying to run from the build directory, so `CMAKE_BUILD_WITH_INSTALL_RPATH` should be safe enough to use. `SKBUILD_CONFIGURE_OPTIONS='-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON'`...

Ahh, yes. So then the toolchain file should be provided.

As of CMake 3.21 (and we have 3.22 via pip now), you can just [set the `CMAKE_TOOLCHAIN_FILE` envvar](https://cmake.org/cmake/help/latest/envvar/CMAKE_TOOLCHAIN_FILE.html#envvar:CMAKE_TOOLCHAIN_FILE). No need to muck around with symlinks. :D

Shouldn't the toolchain be added globally, and then the environment variable be set by default in pywasmcross.py? All CMake packages will need this, I believe. `-DCMAKE_TOOLCHAIN_FILE` could be removed from...

Also removes the circular dependency issue manual workaround. Do we really need "run" dependencies at all, though? Once the wheel is built, can't it just `install_requires` on other packages, and...