Henry Schreiner

Results 2524 comments of Henry Schreiner

> maybe I just don't need these? For FindPython, you can use [`python_add_library`](https://cmake.org/cmake/help/latest/module/FindPython.html#commands).

```cmake add_executable(myexe ...) target_link_libraries(myexe PRIVATE Python::Python) ``` ?

Actually, I was thinking scikit-build-core; it's a little tricker in scikit-build, since we don't have the minimum version set were we can read it in the old system. Maybe we...

It looks like the logic is incorrect for passing this through properly. It was only designed for `setup.py` commands. :( I think https://github.com/scikit-build/scikit-build/blob/676e110315a971abb856edbd6df0c74293e5ba2d/skbuild/setuptools_wrap.py#L114-L115 needs to respect having it already set...

Thank you for working on this! I'll try to detail the current status soon, probably in such a way that is useful for you & PEP 720 as well as...

Do you have to have `sphinxcontrib-devhelp` installed? This is being loaded by `pkg_resources`'s global loader even though it is not used by us.

Yeah, we disable this one: https://github.com/scikit-build/scikit-build/blob/bd8802fb7cbf04e354d0c841efed3c0ee6eff448/pyproject.toml#L184 Since it's coming from inside setuptools itself. (setuptools/command/test.py is calling it, not us). We'll be removing the "test" command customization soon, since it's heavily...

That’s not triggered by scikit-build. You have a sphinxcontrib extension installed that is triggering it. The old mechanism hooked onto the import system.

Though I should see if we can avoid importing pkgutils.

FYI, I'm pretty sure (but haven't tested it) that this works correctly in scikit-build-core. The problem here is tied to the fact scikit-build's output is built around a package directory,...