felony icon indicating copy to clipboard operation
felony copied to clipboard

Error messages

Open laszlokorte opened this issue 9 years ago • 2 comments
trafficstars

When entering invalid public keys, signed messages or encrypted messages it just does nothing. An error message should be displayed.

laszlokorte avatar Jul 04 '16 13:07 laszlokorte

Agreed. I would love a PR 😺

henryboldi avatar Jul 04 '16 13:07 henryboldi

https://github.com/henryboldi/felony/blob/master/app/actions/KeychainActions.js#L10 https://github.com/henryboldi/felony/blob/master/app/actions/KeychainActions.js#L25 https://github.com/henryboldi/felony/blob/master/app/actions/AliasesActions.js#L12 https://github.com/henryboldi/felony/blob/master/app/actions/AliasesActions.js#L27 https://github.com/henryboldi/felony/blob/master/package.js#L96 https://github.com/henryboldi/felony/blob/master/main.development.js#L43

Are all the places where an error is caught and silently logged/ignored. I'll probably submit a PR later today, leaving this here for my reference (or someone to snipe me with :dart:)

sleepypikachu avatar Jul 04 '16 14:07 sleepypikachu